Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brave and opera to browser appnames #131

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Conversation

johan-bjareholt
Copy link
Member

@johan-bjareholt johan-bjareholt commented Mar 8, 2019

@ghost ghost assigned johan-bjareholt Mar 8, 2019
@ghost ghost added the review label Mar 8, 2019
@ErikBjare
Copy link
Member

ErikBjare commented Mar 8, 2019

There's just one thing that worries me in general about the multi-browser support: there should be one bucket for each of Chrome, Chrome Beta, Firefox, Firefox Nightly, Brave, Opera, etc to prevent issues where there are two instances concurrently (still achievable by using profiles or portable installs, but far less likely).

Maybe worthy of an issue though?

@johan-bjareholt
Copy link
Member Author

@ErikBjare Yeah, I wrote about that in the forum thread. We currently just check the useragent for firefox/chrome but that should be possible to extend.

@johan-bjareholt
Copy link
Member Author

@ErikBjare Updated, now actually works. Tested with Opera with the following aw-watcher-web patch
ActivityWatch/aw-watcher-web#37

Together with the changes to choose all buckets in #141 by @nicolae-stroncea it works very well with running firefox, chrome and opera all with watchers running and visualizing them summaried together.

@johan-bjareholt johan-bjareholt changed the title WIP: Add brave and opera to browser appnames Add brave and opera to browser appnames Jul 4, 2019
@ErikBjare
Copy link
Member

@johan-bjareholt Didn't we talk about aw-watcher-web-chrome becoming aw-watcher-web-chromium for Chromium? If so shouldn't we split the appnames['chrome'] into chrome and chromium variants?

@johan-bjareholt
Copy link
Member Author

@ErikBjare That is impossible to know, this is the useragent for Chromium on Linux

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

No mention at all that it's Chromium.

@ErikBjare ErikBjare merged commit aa49bfc into master Jul 11, 2019
@ErikBjare ErikBjare deleted the dev/more-browser-appnames branch July 11, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants